diff options
| author | Jason Baron <jbaron@akamai.com> | 2017-01-24 21:49:41 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-01-25 13:23:36 -0500 |
| commit | 56d806222ace4c3aeae516cd7a855340fb2839d8 (patch) | |
| tree | 3f47042bfc3d9fec74addd06837e37ae3c91eb5d | |
| parent | 5207f3996338e1db71363fe381c81aaf1e54e4e3 (diff) | |
| download | linux-stable-56d806222ace4c3aeae516cd7a855340fb2839d8.tar.gz linux-stable-56d806222ace4c3aeae516cd7a855340fb2839d8.tar.bz2 linux-stable-56d806222ace4c3aeae516cd7a855340fb2839d8.zip | |
tcp: correct memory barrier usage in tcp_check_space()
sock_reset_flag() maps to __clear_bit() not the atomic version clear_bit().
Thus, we need smp_mb(), smp_mb__after_atomic() is not sufficient.
Fixes: 3c7151275c0c ("tcp: add memory barriers to write space paths")
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Jason Baron <jbaron@akamai.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Reported-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/tcp_input.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 6c790754ae3e..41dcbd568cbe 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -5078,7 +5078,7 @@ static void tcp_check_space(struct sock *sk) if (sock_flag(sk, SOCK_QUEUE_SHRUNK)) { sock_reset_flag(sk, SOCK_QUEUE_SHRUNK); /* pairs with tcp_poll() */ - smp_mb__after_atomic(); + smp_mb(); if (sk->sk_socket && test_bit(SOCK_NOSPACE, &sk->sk_socket->flags)) { tcp_new_space(sk); |