diff options
| author | Xin Long <lucien.xin@gmail.com> | 2017-01-24 14:01:53 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-01-25 12:26:55 -0500 |
| commit | 6f29a130613191d3c6335169febe002cba00edf5 (patch) | |
| tree | d2581877c6cae4819e17ff33897f930d05ce4e65 | |
| parent | ec221a17a638dec4d9b0ba3e5817113f249dd194 (diff) | |
| download | linux-stable-6f29a130613191d3c6335169febe002cba00edf5.tar.gz linux-stable-6f29a130613191d3c6335169febe002cba00edf5.tar.bz2 linux-stable-6f29a130613191d3c6335169febe002cba00edf5.zip | |
sctp: sctp_addr_id2transport should verify the addr before looking up assoc
sctp_addr_id2transport is a function for sockopt to look up assoc by
address. As the address is from userspace, it can be a v4-mapped v6
address. But in sctp protocol stack, it always handles a v4-mapped
v6 address as a v4 address. So it's necessary to convert it to a v4
address before looking up assoc by address.
This patch is to fix it by calling sctp_verify_addr in which it can do
this conversion before calling sctp_endpoint_lookup_assoc, just like
what sctp_sendmsg and __sctp_connect do for the address from users.
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/sctp/socket.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 318c6786d653..37eeab7899fc 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -235,8 +235,12 @@ static struct sctp_transport *sctp_addr_id2transport(struct sock *sk, sctp_assoc_t id) { struct sctp_association *addr_asoc = NULL, *id_asoc = NULL; - struct sctp_transport *transport; + struct sctp_af *af = sctp_get_af_specific(addr->ss_family); union sctp_addr *laddr = (union sctp_addr *)addr; + struct sctp_transport *transport; + + if (sctp_verify_addr(sk, laddr, af->sockaddr_len)) + return NULL; addr_asoc = sctp_endpoint_lookup_assoc(sctp_sk(sk)->ep, laddr, |