diff options
| author | Jingoo Han <jg1.han@samsung.com> | 2013-03-07 18:37:38 -0800 |
|---|---|---|
| committer | Bryan Wu <cooloney@gmail.com> | 2013-04-01 11:04:49 -0700 |
| commit | 84f6942cde279e812c59eed456d1f43a39ca6c40 (patch) | |
| tree | 9dd1e0f672a1f2949e8b5d8750979ec2696f7527 | |
| parent | e9dd68cf148994bf2eb718c540a472170b1ad4d3 (diff) | |
| download | linux-stable-84f6942cde279e812c59eed456d1f43a39ca6c40.tar.gz linux-stable-84f6942cde279e812c59eed456d1f43a39ca6c40.tar.bz2 linux-stable-84f6942cde279e812c59eed456d1f43a39ca6c40.zip | |
leds: leds-lt3593: set devm_gpio_request_one() flags param correctly
The devm_gpio_request_one() flags parameter was set to:
GPIOF_DIR_OUT | state
GPIOF_DIR_OUT and GPIOF_DIR_IN are defined as below:
GPIOF_DIR_OUT (0 << 0)
GPIOF_DIR_IN (1 << 0)
So, when 'state' is 1, the gpio pin can be set as input, instead
of output.
To prevent this problem, GPIOF_OUT_INIT flags should be used when
using devm_gpio_request_one().
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
| -rw-r--r-- | drivers/leds/leds-lt3593.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/leds/leds-lt3593.c b/drivers/leds/leds-lt3593.c index c9b9e1fec587..ca48a7d5502d 100644 --- a/drivers/leds/leds-lt3593.c +++ b/drivers/leds/leds-lt3593.c @@ -106,8 +106,9 @@ static int create_lt3593_led(const struct gpio_led *template, if (!template->retain_state_suspended) led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME; - ret = devm_gpio_request_one(parent, template->gpio, - GPIOF_DIR_OUT | state, template->name); + ret = devm_gpio_request_one(parent, template->gpio, state ? + GPIOF_OUT_INIT_HIGH : GPIOF_OUT_INIT_LOW, + template->name); if (ret < 0) return ret; |