diff options
| author | Pawel Laszczak <pawell@cadence.com> | 2021-06-23 09:02:47 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-08-12 13:20:59 +0200 |
| commit | 134e27da543d1e9f3c3b988c40e20e1269423bff (patch) | |
| tree | e336ddab13b7233c2e2d0e7aaebcd077ef2b4fe2 | |
| parent | df1c6eec4ea124e5ffd81fc81714d5d30510bb17 (diff) | |
| download | linux-stable-134e27da543d1e9f3c3b988c40e20e1269423bff.tar.gz linux-stable-134e27da543d1e9f3c3b988c40e20e1269423bff.tar.bz2 linux-stable-134e27da543d1e9f3c3b988c40e20e1269423bff.zip | |
usb: cdns3: Fixed incorrect gadget state
commit aa35772f61752d4c636d46be51a4f7ca6c029ee6 upstream.
For delayed status phase, the usb_gadget->state was set
to USB_STATE_ADDRESS and it has never been updated to
USB_STATE_CONFIGURED.
Patch updates the gadget state to correct USB_STATE_CONFIGURED.
As a result of this bug the controller was not able to enter to
Test Mode while using MSC function.
Cc: <stable@vger.kernel.org>
Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Link: https://lore.kernel.org/r/20210623070247.46151-1-pawell@gli-login.cadence.com
Signed-off-by: Peter Chen <peter.chen@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/cdns3/ep0.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/cdns3/ep0.c b/drivers/usb/cdns3/ep0.c index 666cebd9c5f2..390779e2294d 100644 --- a/drivers/usb/cdns3/ep0.c +++ b/drivers/usb/cdns3/ep0.c @@ -736,6 +736,7 @@ static int cdns3_gadget_ep0_queue(struct usb_ep *ep, request->actual = 0; priv_dev->status_completion_no_call = true; priv_dev->pending_status_request = request; + usb_gadget_set_state(&priv_dev->gadget, USB_STATE_CONFIGURED); spin_unlock_irqrestore(&priv_dev->lock, flags); /* |