diff options
| author | Dongliang Mu <mudongliangabcd@gmail.com> | 2021-07-20 18:01:16 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-08-12 13:21:04 +0200 |
| commit | a5bf7ef13ebf6adf62a69ab3542d4fc0564c082e (patch) | |
| tree | cd7f4abccf0171c3e14e46aae9042b79bc693ee1 | |
| parent | 27991c78d6303425c116fd0583d6ef22a837c70a (diff) | |
| download | linux-stable-a5bf7ef13ebf6adf62a69ab3542d4fc0564c082e.tar.gz linux-stable-a5bf7ef13ebf6adf62a69ab3542d4fc0564c082e.tar.bz2 linux-stable-a5bf7ef13ebf6adf62a69ab3542d4fc0564c082e.zip | |
spi: meson-spicc: fix memory leak in meson_spicc_remove
commit 8311ee2164c5cd1b63a601ea366f540eae89f10e upstream.
In meson_spicc_probe, the error handling code needs to clean up master
by calling spi_master_put, but the remove function does not have this
function call. This will lead to memory leak of spicc->master.
Reported-by: Dongliang Mu <mudongliangabcd@gmail.com>
Fixes: 454fa271bc4e("spi: Add Meson SPICC driver")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Link: https://lore.kernel.org/r/20210720100116.1438974-1-mudongliangabcd@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/spi/spi-meson-spicc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c index f3f10443f9e2..3c841ae0a3e9 100644 --- a/drivers/spi/spi-meson-spicc.c +++ b/drivers/spi/spi-meson-spicc.c @@ -597,6 +597,8 @@ static int meson_spicc_remove(struct platform_device *pdev) clk_disable_unprepare(spicc->core); + spi_master_put(spicc->master); + return 0; } |