diff options
| author | Dinghao Liu <dinghao.liu@zju.edu.cn> | 2020-05-22 16:08:38 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-10-01 13:18:04 +0200 |
| commit | bb6e9827da759c84a763899f03e88621bdcf5ebc (patch) | |
| tree | a2d277f545767d7c9aaaf81cdcb1714f0b6936b6 | |
| parent | 1aa9de56d7626342343fa2d93a6923a6142c737e (diff) | |
| download | linux-stable-bb6e9827da759c84a763899f03e88621bdcf5ebc.tar.gz linux-stable-bb6e9827da759c84a763899f03e88621bdcf5ebc.tar.bz2 linux-stable-bb6e9827da759c84a763899f03e88621bdcf5ebc.zip | |
gpio: rcar: Fix runtime PM imbalance on error
[ Upstream commit 6f8cd246411575703d9312888b70705c396b53a9 ]
pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20200522080839.32612-1-dinghao.liu@zju.edu.cn
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/gpio/gpio-rcar.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 187984d26f47..f0b6c68e848e 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -250,8 +250,10 @@ static int gpio_rcar_request(struct gpio_chip *chip, unsigned offset) int error; error = pm_runtime_get_sync(p->dev); - if (error < 0) + if (error < 0) { + pm_runtime_put(p->dev); return error; + } error = pinctrl_gpio_request(chip->base + offset); if (error) |