diff options
author | Ruliang Lin <u202112092@hust.edu.cn> | 2023-05-04 14:50:53 +0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-05-17 11:53:37 +0200 |
commit | 4e875cf90d75fcdb3e1b516c386cc6caef418a03 (patch) | |
tree | 621b43902056c05599a0c7076c5538148b3aa5e7 | |
parent | 7887397338a55a2439ba8db6d9a93cbe4094d912 (diff) | |
download | linux-stable-4e875cf90d75fcdb3e1b516c386cc6caef418a03.tar.gz linux-stable-4e875cf90d75fcdb3e1b516c386cc6caef418a03.tar.bz2 linux-stable-4e875cf90d75fcdb3e1b516c386cc6caef418a03.zip |
ALSA: caiaq: input: Add error handling for unsupported input methods in `snd_usb_caiaq_input_init`
[ Upstream commit 0d727e1856ef22dd9337199430258cb64cbbc658 ]
Smatch complains that:
snd_usb_caiaq_input_init() warn: missing error code 'ret'
This patch adds a new case to handle the situation where the
device does not support any input methods in the
`snd_usb_caiaq_input_init` function. It returns an `-EINVAL` error code
to indicate that no input methods are supported on the device.
Fixes: 523f1dce3743 ("[ALSA] Add Native Instrument usb audio device support")
Signed-off-by: Ruliang Lin <u202112092@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Acked-by: Daniel Mack <daniel@zonque.org>
Link: https://lore.kernel.org/r/20230504065054.3309-1-u202112092@hust.edu.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r-- | sound/usb/caiaq/input.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/usb/caiaq/input.c b/sound/usb/caiaq/input.c index 1e2cf2f08eec..84f26dce7f5d 100644 --- a/sound/usb/caiaq/input.c +++ b/sound/usb/caiaq/input.c @@ -804,6 +804,7 @@ int snd_usb_caiaq_input_init(struct snd_usb_caiaqdev *cdev) default: /* no input methods supported on this device */ + ret = -EINVAL; goto exit_free_idev; } |