diff options
| author | Colin Ian King <colin.king@canonical.com> | 2017-01-11 15:36:20 +0000 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2017-01-18 16:32:44 +0000 |
| commit | b98acbff9a05b371c5f0ca6e44a3af8ce9274379 (patch) | |
| tree | d6835885f859a456e62ce93621041138d6a54f9b | |
| parent | d00b74613fb18dfd0a5aa99270ee2e72d5c808d7 (diff) | |
| download | linux-stable-b98acbff9a05b371c5f0ca6e44a3af8ce9274379.tar.gz linux-stable-b98acbff9a05b371c5f0ca6e44a3af8ce9274379.tar.bz2 linux-stable-b98acbff9a05b371c5f0ca6e44a3af8ce9274379.zip | |
regulator: twl6030: fix range comparison, allowing vsel = 59
The range min_uV > 1350000 && min_uV <= 150000 is never reachable
because of a typo in the previous range check and hence vsel = 59
is never reached. Fix the previous range check to enable the
vsel = 59 setting.
Fixes CoverityScan CID#728454 ("Logially dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/regulator/twl6030-regulator.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/twl6030-regulator.c b/drivers/regulator/twl6030-regulator.c index 4864b9d742c0..716191046a70 100644 --- a/drivers/regulator/twl6030-regulator.c +++ b/drivers/regulator/twl6030-regulator.c @@ -452,7 +452,7 @@ static int twl6030smps_map_voltage(struct regulator_dev *rdev, int min_uV, vsel = 62; else if ((min_uV > 1800000) && (min_uV <= 1900000)) vsel = 61; - else if ((min_uV > 1350000) && (min_uV <= 1800000)) + else if ((min_uV > 1500000) && (min_uV <= 1800000)) vsel = 60; else if ((min_uV > 1350000) && (min_uV <= 1500000)) vsel = 59; |