summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrancesco Dolcini <francesco.dolcini@toradex.com>2024-07-31 16:06:57 +0200
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2024-08-03 16:47:13 +0100
commitde80af5c2ffd9c3f02792f6979296cb6f74e82e5 (patch)
treede53aa1191ed4b21cae65895129a37721ce7e775
parent8a3dcc970dc57b358c8db2702447bf0af4e0d83a (diff)
downloadlinux-stable-de80af5c2ffd9c3f02792f6979296cb6f74e82e5.tar.gz
linux-stable-de80af5c2ffd9c3f02792f6979296cb6f74e82e5.tar.bz2
linux-stable-de80af5c2ffd9c3f02792f6979296cb6f74e82e5.zip
iio: adc: ads1119: Fix IRQ flags
Remove IRQF_TRIGGER_FALLING flag from irq request, this should come from the platform firmware and should not be hard-coded into the driver. Add IRQF_ONESHOT flag to the irq request, the interrupt should not be re-activated in interrupt context, it should be done only after the device irq handler run. Fixes: a9306887eba4 ("iio: adc: ti-ads1119: Add driver") Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> Reviwed-by: João Paulo Gonçalves <jpaulo.silvagoncalves@gmail.com> Link: https://patch.msgid.link/20240731140657.88265-1-francesco@dolcini.it Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
-rw-r--r--drivers/iio/adc/ti-ads1119.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/adc/ti-ads1119.c b/drivers/iio/adc/ti-ads1119.c
index 630f5d5f9a60..d649980479e4 100644
--- a/drivers/iio/adc/ti-ads1119.c
+++ b/drivers/iio/adc/ti-ads1119.c
@@ -735,7 +735,7 @@ static int ads1119_probe(struct i2c_client *client)
if (client->irq > 0) {
ret = devm_request_threaded_irq(dev, client->irq,
ads1119_irq_handler,
- NULL, IRQF_TRIGGER_FALLING,
+ NULL, IRQF_ONESHOT,
"ads1119", indio_dev);
if (ret)
return dev_err_probe(dev, ret,