summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSaurabh Sengar <ssengar@linux.microsoft.com>2024-08-29 12:43:11 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-09-03 12:37:37 +0200
commitfb1adbd7e50f3d2de56d0a2bb0700e2e819a329e (patch)
tree62430cb7bcc706598a92f5fbc53eb10e636aba47
parent7d32e779eb9add47bfdb4731c4d4ff443a7f7fa6 (diff)
downloadlinux-stable-fb1adbd7e50f3d2de56d0a2bb0700e2e819a329e.tar.gz
linux-stable-fb1adbd7e50f3d2de56d0a2bb0700e2e819a329e.tar.bz2
linux-stable-fb1adbd7e50f3d2de56d0a2bb0700e2e819a329e.zip
uio_hv_generic: Fix kernel NULL pointer dereference in hv_uio_rescind
For primary VM Bus channels, primary_channel pointer is always NULL. This pointer is valid only for the secondary channels. Also, rescind callback is meant for primary channels only. Fix NULL pointer dereference by retrieving the device_obj from the parent for the primary channel. Cc: stable@vger.kernel.org Fixes: ca3cda6fcf1e ("uio_hv_generic: add rescind support") Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com> Signed-off-by: Naman Jain <namjain@linux.microsoft.com> Link: https://lore.kernel.org/r/20240829071312.1595-2-namjain@linux.microsoft.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/uio/uio_hv_generic.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c
index b45653752301..e3e66a3e85a8 100644
--- a/drivers/uio/uio_hv_generic.c
+++ b/drivers/uio/uio_hv_generic.c
@@ -106,10 +106,11 @@ static void hv_uio_channel_cb(void *context)
/*
* Callback from vmbus_event when channel is rescinded.
+ * It is meant for rescind of primary channels only.
*/
static void hv_uio_rescind(struct vmbus_channel *channel)
{
- struct hv_device *hv_dev = channel->primary_channel->device_obj;
+ struct hv_device *hv_dev = channel->device_obj;
struct hv_uio_private_data *pdata = hv_get_drvdata(hv_dev);
/*