diff options
| author | Boris Burkov <boris@bur.io> | 2023-04-05 12:43:58 -0700 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-04-21 00:28:20 +0200 |
| commit | e9f59429b87d35cf23ae9ca19629bd686a1c0304 (patch) | |
| tree | 9085681f1396186b62f12773c7e255c07e4f5ae6 | |
| parent | 68d99ab0e9221ef54506f827576c5a914680eeaf (diff) | |
| download | linux-stable-e9f59429b87d35cf23ae9ca19629bd686a1c0304.tar.gz linux-stable-e9f59429b87d35cf23ae9ca19629bd686a1c0304.tar.bz2 linux-stable-e9f59429b87d35cf23ae9ca19629bd686a1c0304.zip | |
btrfs: set default discard iops_limit to 1000
Previously, the default was a relatively conservative 10. This results
in a 100ms delay, so with ~300 discards in a commit, it takes the full
30s till the next commit to finish the discards. On a workstation, this
results in the disk never going idle, wasting power/battery, etc.
Set the default to 1000, which results in using the smallest possible
delay, currently, which is 1ms. This has shown to not pathologically
keep the disk busy by the original reporter.
Link: https://lore.kernel.org/linux-btrfs/Y%2F+n1wS%2F4XAH7X1p@nz/
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2182228
CC: stable@vger.kernel.org # 6.2+
Reviewed-by: Neal Gompa <neal@gompa.dev
Signed-off-by: Boris Burkov <boris@bur.io>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/discard.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/discard.c b/fs/btrfs/discard.c index 317aeff6c1da..0bc526f5fcd9 100644 --- a/fs/btrfs/discard.c +++ b/fs/btrfs/discard.c @@ -60,7 +60,7 @@ #define BTRFS_DISCARD_TARGET_MSEC (6 * 60 * 60UL * MSEC_PER_SEC) #define BTRFS_DISCARD_MIN_DELAY_MSEC (1UL) #define BTRFS_DISCARD_MAX_DELAY_MSEC (1000UL) -#define BTRFS_DISCARD_MAX_IOPS (10U) +#define BTRFS_DISCARD_MAX_IOPS (1000U) /* Monotonically decreasing minimum length filters after index 0 */ static int discard_minlen[BTRFS_NR_DISCARD_LISTS] = { |