summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChih-Yen Chang <cc85nod@gmail.com>2023-05-06 00:03:54 +0900
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-05-24 17:30:21 +0100
commit778aae5a513ea09aa5addfa352bd70a5b71dda85 (patch)
tree904d197ef1b43a858c74a9442266af35164389d4
parent69e576f03e2e4c41402d1673a96b0cdad25240e2 (diff)
downloadlinux-stable-778aae5a513ea09aa5addfa352bd70a5b71dda85.tar.gz
linux-stable-778aae5a513ea09aa5addfa352bd70a5b71dda85.tar.bz2
linux-stable-778aae5a513ea09aa5addfa352bd70a5b71dda85.zip
ksmbd: allocate one more byte for implied bcc[0]
commit 443d61d1fa9faa60ef925513d83742902390100f upstream. ksmbd_smb2_check_message allows client to return one byte more, so we need to allocate additional memory in ksmbd_conn_handler_loop to avoid out-of-bound access. Cc: stable@vger.kernel.org Signed-off-by: Chih-Yen Chang <cc85nod@gmail.com> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/ksmbd/connection.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ksmbd/connection.c b/fs/ksmbd/connection.c
index 4ed379f9b1aa..4882a812ea86 100644
--- a/fs/ksmbd/connection.c
+++ b/fs/ksmbd/connection.c
@@ -351,7 +351,8 @@ int ksmbd_conn_handler_loop(void *p)
break;
/* 4 for rfc1002 length field */
- size = pdu_size + 4;
+ /* 1 for implied bcc[0] */
+ size = pdu_size + 4 + 1;
conn->request_buf = kvmalloc(size, GFP_KERNEL);
if (!conn->request_buf)
break;