summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaulo Alcantara <pc@manguebit.com>2024-04-02 16:34:00 -0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-04-10 16:36:05 +0200
commit0a15ba88a32fa7a516aff7ffd27befed5334dff2 (patch)
tree5d0932969789f7a616e38235a8d764f9259c1cb3
parentf92739fdd4522c4291277136399353d7c341fae4 (diff)
downloadlinux-stable-0a15ba88a32fa7a516aff7ffd27befed5334dff2.tar.gz
linux-stable-0a15ba88a32fa7a516aff7ffd27befed5334dff2.tar.bz2
linux-stable-0a15ba88a32fa7a516aff7ffd27befed5334dff2.zip
smb: client: fix potential UAF in is_valid_oplock_break()
commit 69ccf040acddf33a3a85ec0f6b45ef84b0f7ec29 upstream. Skip sessions that are being teared down (status == SES_EXITING) to avoid UAF. Cc: stable@vger.kernel.org Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/smb/client/misc.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/smb/client/misc.c b/fs/smb/client/misc.c
index c2137ea3c253..ef573e3f8e52 100644
--- a/fs/smb/client/misc.c
+++ b/fs/smb/client/misc.c
@@ -489,6 +489,8 @@ is_valid_oplock_break(char *buffer, struct TCP_Server_Info *srv)
/* look up tcon based on tid & uid */
spin_lock(&cifs_tcp_ses_lock);
list_for_each_entry(ses, &pserver->smb_ses_list, smb_ses_list) {
+ if (cifs_ses_exiting(ses))
+ continue;
list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
if (tcon->tid != buf->Tid)
continue;