summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaulo Alcantara <pc@manguebit.com>2024-04-02 16:33:59 -0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-04-10 16:36:05 +0200
commit21fed37d2bdcde33453faf61d3d4d96c355f04bd (patch)
treefd0e08142e79e2f9e9a4819c942169b16b56695c
parent10e17ca4000ec34737bde002a13435c38ace2682 (diff)
downloadlinux-stable-21fed37d2bdcde33453faf61d3d4d96c355f04bd.tar.gz
linux-stable-21fed37d2bdcde33453faf61d3d4d96c355f04bd.tar.bz2
linux-stable-21fed37d2bdcde33453faf61d3d4d96c355f04bd.zip
smb: client: fix potential UAF in smb2_is_valid_oplock_break()
commit 22863485a4626ec6ecf297f4cc0aef709bc862e4 upstream. Skip sessions that are being teared down (status == SES_EXITING) to avoid UAF. Cc: stable@vger.kernel.org Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/smb/client/smb2misc.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/smb/client/smb2misc.c b/fs/smb/client/smb2misc.c
index 82b84a4941dd..3f4c37458f97 100644
--- a/fs/smb/client/smb2misc.c
+++ b/fs/smb/client/smb2misc.c
@@ -697,6 +697,8 @@ smb2_is_valid_oplock_break(char *buffer, struct TCP_Server_Info *server)
/* look up tcon based on tid & uid */
spin_lock(&cifs_tcp_ses_lock);
list_for_each_entry(ses, &pserver->smb_ses_list, smb_ses_list) {
+ if (cifs_ses_exiting(ses))
+ continue;
list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
spin_lock(&tcon->open_file_lock);