diff options
| author | Saurav Kashyap <skashyap@marvell.com> | 2024-02-27 22:11:23 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-04-03 15:11:57 +0200 |
| commit | b7deb675d674f44e0ddbab87fee8f9f098925e73 (patch) | |
| tree | 3db3339b2264e767b362b24a126fb4d09a5a36ea | |
| parent | 8f0d32004e3a572bb77e6c11c2797c87f8c9703d (diff) | |
| download | linux-stable-b7deb675d674f44e0ddbab87fee8f9f098925e73.tar.gz linux-stable-b7deb675d674f44e0ddbab87fee8f9f098925e73.tar.bz2 linux-stable-b7deb675d674f44e0ddbab87fee8f9f098925e73.zip | |
scsi: qla2xxx: Fix double free of the ha->vp_map pointer
commit e288285d47784fdcf7c81be56df7d65c6f10c58b upstream.
Coverity scan reported potential risk of double free of the pointer
ha->vp_map. ha->vp_map was freed in qla2x00_mem_alloc(), and again freed
in function qla2x00_mem_free(ha).
Assign NULL to vp_map and kfree take care of NULL.
Cc: stable@vger.kernel.org
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240227164127.36465-8-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/scsi/qla2xxx/qla_os.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 7ef59bc62bf1..931bdaeaee1d 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -4602,6 +4602,7 @@ fail_free_init_cb: ha->init_cb_dma = 0; fail_free_vp_map: kfree(ha->vp_map); + ha->vp_map = NULL; fail: ql_log(ql_log_fatal, NULL, 0x0030, "Memory allocation failure.\n"); |