summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaulo Alcantara <pc@manguebit.com>2024-04-02 16:33:55 -0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-04-10 16:38:21 +0200
commit5b5475ce69f02ecc1b13ea23106e5b89c690429b (patch)
treef85380600a4295c7bb6d72f33fb60dc3a0c5443a
parent3402faf78b2516b0af1259baff50cc8453ef0bd1 (diff)
downloadlinux-stable-5b5475ce69f02ecc1b13ea23106e5b89c690429b.tar.gz
linux-stable-5b5475ce69f02ecc1b13ea23106e5b89c690429b.tar.bz2
linux-stable-5b5475ce69f02ecc1b13ea23106e5b89c690429b.zip
smb: client: fix potential UAF in cifs_stats_proc_write()
commit d3da25c5ac84430f89875ca7485a3828150a7e0a upstream. Skip sessions that are being teared down (status == SES_EXITING) to avoid UAF. Cc: stable@vger.kernel.org Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/smb/client/cifs_debug.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/smb/client/cifs_debug.c b/fs/smb/client/cifs_debug.c
index 4f4be57b6f5b..739525f976ce 100644
--- a/fs/smb/client/cifs_debug.c
+++ b/fs/smb/client/cifs_debug.c
@@ -658,6 +658,8 @@ static ssize_t cifs_stats_proc_write(struct file *file,
}
#endif /* CONFIG_CIFS_STATS2 */
list_for_each_entry(ses, &server->smb_ses_list, smb_ses_list) {
+ if (cifs_ses_exiting(ses))
+ continue;
list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
atomic_set(&tcon->num_smbs_sent, 0);
spin_lock(&tcon->stat_lock);