summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaulo Alcantara <pc@manguebit.com>2024-04-02 16:33:58 -0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-04-10 16:38:21 +0200
commita8344e2b69bde63f713b0aa796d70dbeadffddfb (patch)
tree80ff2d208aa96931cd0e125f2423c95db0a5e005
parent3dba0e5276f131e36d6d8043191d856f49238628 (diff)
downloadlinux-stable-a8344e2b69bde63f713b0aa796d70dbeadffddfb.tar.gz
linux-stable-a8344e2b69bde63f713b0aa796d70dbeadffddfb.tar.bz2
linux-stable-a8344e2b69bde63f713b0aa796d70dbeadffddfb.zip
smb: client: fix potential UAF in smb2_is_valid_lease_break()
commit 705c76fbf726c7a2f6ff9143d4013b18daaaebf1 upstream. Skip sessions that are being teared down (status == SES_EXITING) to avoid UAF. Cc: stable@vger.kernel.org Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/smb/client/smb2misc.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/smb/client/smb2misc.c b/fs/smb/client/smb2misc.c
index 3f4c37458f97..cc72be5a93a9 100644
--- a/fs/smb/client/smb2misc.c
+++ b/fs/smb/client/smb2misc.c
@@ -622,6 +622,8 @@ smb2_is_valid_lease_break(char *buffer, struct TCP_Server_Info *server)
/* look up tcon based on tid & uid */
spin_lock(&cifs_tcp_ses_lock);
list_for_each_entry(ses, &pserver->smb_ses_list, smb_ses_list) {
+ if (cifs_ses_exiting(ses))
+ continue;
list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
spin_lock(&tcon->open_file_lock);
cifs_stats_inc(