diff options
author | Jason A. Donenfeld <Jason@zx2c4.com> | 2022-05-09 13:40:55 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-05-30 09:27:16 +0200 |
commit | 8fe9ac5ed215ade6f1cd23415b3474fbb6e3f7fa (patch) | |
tree | 48ec8a230323c41d1188dc7e482ae8c05ec0000f /COPYING | |
parent | 4f8ab1ca8aac134d1262702e18947e53d498055a (diff) | |
download | linux-stable-8fe9ac5ed215ade6f1cd23415b3474fbb6e3f7fa.tar.gz linux-stable-8fe9ac5ed215ade6f1cd23415b3474fbb6e3f7fa.tar.bz2 linux-stable-8fe9ac5ed215ade6f1cd23415b3474fbb6e3f7fa.zip |
random: avoid initializing twice in credit race
commit fed7ef061686cc813b1f3d8d0edc6c35b4d3537b upstream.
Since all changes of crng_init now go through credit_init_bits(), we can
fix a long standing race in which two concurrent callers of
credit_init_bits() have the new bit count >= some threshold, but are
doing so with crng_init as a lower threshold, checked outside of a lock,
resulting in crng_reseed() or similar being called twice.
In order to fix this, we can use the original cmpxchg value of the bit
count, and only change crng_init when the bit count transitions from
below a threshold to meeting the threshold.
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions