diff options
author | Jakub Kicinski <jakub.kicinski@netronome.com> | 2019-04-17 10:51:19 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-04-18 16:51:03 -0700 |
commit | 9188d5ca454fd665145904267e726e9e8d122f5c (patch) | |
tree | 5ae8e056f8215559af87108a39e46d203876ac0e /Documentation | |
parent | e0c1d14a1a3211dccf0540a6703ffbd5d2a75bdb (diff) | |
download | linux-stable-9188d5ca454fd665145904267e726e9e8d122f5c.tar.gz linux-stable-9188d5ca454fd665145904267e726e9e8d122f5c.tar.bz2 linux-stable-9188d5ca454fd665145904267e726e9e8d122f5c.zip |
net/tls: fix refcount adjustment in fallback
Unlike atomic_add(), refcount_add() does not deal well
with a negative argument. TLS fallback code reallocates
the skb and is very likely to shrink the truesize, leading to:
[ 189.513254] WARNING: CPU: 5 PID: 0 at lib/refcount.c:81 refcount_add_not_zero_checked+0x15c/0x180
Call Trace:
refcount_add_checked+0x6/0x40
tls_enc_skb+0xb93/0x13e0 [tls]
Once wmem_allocated count saturates the application can no longer
send data on the socket. This is similar to Eric's fixes for GSO,
TCP:
commit 7ec318feeed1 ("tcp: gso: avoid refcount_t warning from tcp_gso_segment()")
and UDP:
commit 575b65bc5bff ("udp: avoid refcount_t saturation in __udp_gso_segment()").
Unlike the GSO case, for TLS fallback it's likely that the skb has
shrunk, so the "likely" annotation is the other way around (likely
branch being "sub").
Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: John Hurley <john.hurley@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions