diff options
author | Jean-Philippe Brucker <jean-philippe.brucker@arm.com> | 2019-05-24 13:52:19 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-07-03 13:14:49 +0200 |
commit | 3919d91f4d367de8c01a3e76373fb30c76ce916b (patch) | |
tree | be7bb666853fa94675d65d657bf614f76581dac2 /Makefile | |
parent | 9c423fd89a2b8624ca0a0eb2a1bd440ad0db8cf5 (diff) | |
download | linux-stable-3919d91f4d367de8c01a3e76373fb30c76ce916b.tar.gz linux-stable-3919d91f4d367de8c01a3e76373fb30c76ce916b.tar.bz2 linux-stable-3919d91f4d367de8c01a3e76373fb30c76ce916b.zip |
arm64: insn: Fix ldadd instruction encoding
commit c5e2edeb01ae9ffbdde95bdcdb6d3614ba1eb195 upstream.
GCC 8.1.0 reports that the ldadd instruction encoding, recently added to
insn.c, doesn't match the mask and couldn't possibly be identified:
linux/arch/arm64/include/asm/insn.h: In function 'aarch64_insn_is_ldadd':
linux/arch/arm64/include/asm/insn.h:280:257: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
Bits [31:30] normally encode the size of the instruction (1 to 8 bytes)
and the current instruction value only encodes the 4- and 8-byte
variants. At the moment only the BPF JIT needs this instruction, and
doesn't require the 1- and 2-byte variants, but to be consistent with
our other ldr and str instruction encodings, clear the size field in the
insn value.
Fixes: 34b8ab091f9ef57a ("bpf, arm64: use more scalable stadd over ldxr / stxr loop in xadd")
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions