diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-06-05 10:51:29 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-08-17 14:24:13 +0200 |
| commit | 5eaa93caa63abf382b319dbe2f032232026740c2 (patch) | |
| tree | ced80a8a0e308809443cf2b908f889937771b252 /arch/powerpc/platforms | |
| parent | ea494e8a9852abd0ba60f69b254ce0d7c38449e2 (diff) | |
| download | linux-stable-5eaa93caa63abf382b319dbe2f032232026740c2.tar.gz linux-stable-5eaa93caa63abf382b319dbe2f032232026740c2.tar.bz2 linux-stable-5eaa93caa63abf382b319dbe2f032232026740c2.zip | |
powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address
[ Upstream commit df5d4b616ee76abc97e5bd348e22659c2b095b1c ]
of_get_next_parent() returns a node pointer with refcount incremented,
we should use of_node_put() on it when not need anymore.
Add missing of_node_put() in the error path to avoid refcount leak.
Fixes: ce21b3c9648a ("[CELL] add support for MSI on Axon-based Cell systems")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220605065129.63906-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'arch/powerpc/platforms')
| -rw-r--r-- | arch/powerpc/platforms/cell/axon_msi.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c index 82335e364c44..f630693c8de7 100644 --- a/arch/powerpc/platforms/cell/axon_msi.c +++ b/arch/powerpc/platforms/cell/axon_msi.c @@ -226,6 +226,7 @@ static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg) if (!prop) { dev_dbg(&dev->dev, "axon_msi: no msi-address-(32|64) properties found\n"); + of_node_put(dn); return -ENOENT; } |