diff options
author | Frederic Weisbecker <fweisbec@gmail.com> | 2011-01-06 15:22:47 +0100 |
---|---|---|
committer | Frederic Weisbecker <fweisbec@gmail.com> | 2011-01-07 17:40:56 +0100 |
commit | 625dbc3b8acbefefefe27e1d7bbc6e53eb4f3f2d (patch) | |
tree | d27741bbc7397b6982ae5f0fd2cb06629c98ea1c /arch/x86/include/asm/perf_event_p4.h | |
parent | 39a6eebda253aa34d659ca9436e3c32ef60473f1 (diff) | |
download | linux-stable-625dbc3b8acbefefefe27e1d7bbc6e53eb4f3f2d.tar.gz linux-stable-625dbc3b8acbefefefe27e1d7bbc6e53eb4f3f2d.tar.bz2 linux-stable-625dbc3b8acbefefefe27e1d7bbc6e53eb4f3f2d.zip |
x86: Save rbp in pt_regs on irq entry
From the x86_64 low level interrupt handlers, the frame pointer is
saved right after the partial pt_regs frame.
rbp is not supposed to be part of the irq partial saved registers,
but it only requires to extend the pt_regs frame by 8 bytes to
do so, plus a tiny stack offset fixup on irq exit.
This changes a bit the semantics or get_irq_entry() that is supposed
to provide only the value of caller saved registers and the cpu
saved frame. However it's a win for unwinders that can walk through
stack frames on top of get_irq_regs() snapshots.
A noticeable impact is that it makes perf events cpu-clock and
task-clock events based callchains working on x86_64.
Let's then save rbp into the irq pt_regs.
As a result with:
perf record -e cpu-clock perf bench sched messaging
perf report --stdio
Before:
20.94% perf [kernel.kallsyms] [k] lock_acquire
|
--- lock_acquire
|
|--44.01%-- __write_nocancel
|
|--43.18%-- __read
|
|--6.08%-- fork
| create_worker
|
|--0.88%-- _dl_fixup
|
|--0.65%-- do_lookup_x
|
|--0.53%-- __GI___libc_read
--4.67%-- [...]
After:
19.23% perf [kernel.kallsyms] [k] __lock_acquire
|
--- __lock_acquire
|
|--97.74%-- lock_acquire
| |
| |--21.82%-- _raw_spin_lock
| | |
| | |--37.26%-- unix_stream_recvmsg
| | | sock_aio_read
| | | do_sync_read
| | | vfs_read
| | | sys_read
| | | system_call
| | | __read
| | |
| | |--24.09%-- unix_stream_sendmsg
| | | sock_aio_write
| | | do_sync_write
| | | vfs_write
| | | sys_write
| | | system_call
| | | __write_nocancel
v2: Fix cfi annotations.
Reported-by: Soeren Sandmann Pedersen <sandmann@redhat.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: H. Peter Anvin <hpa@zytor.com
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Jan Beulich <JBeulich@novell.com>
Diffstat (limited to 'arch/x86/include/asm/perf_event_p4.h')
0 files changed, 0 insertions, 0 deletions