diff options
author | Dexuan Cui <decui@microsoft.com> | 2018-09-23 21:10:43 +0000 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-09-16 08:21:48 +0200 |
commit | 805e0e46eb54e9655bbfe1692b55e59a5b534dba (patch) | |
tree | b8a146d0a23ea09d2855a1c6c39c27d35bddaa66 /arch/x86 | |
parent | 3f3beae228422dbe7dd5497c7750a3ea8402c91e (diff) | |
download | linux-stable-805e0e46eb54e9655bbfe1692b55e59a5b534dba.tar.gz linux-stable-805e0e46eb54e9655bbfe1692b55e59a5b534dba.tar.bz2 linux-stable-805e0e46eb54e9655bbfe1692b55e59a5b534dba.zip |
Drivers: hv: kvp: Fix two "this statement may fall through" warnings
[ Upstream commit fc62c3b1977d62e6374fd6e28d371bb42dfa5c9d ]
We don't need to call process_ib_ipinfo() if message->kvp_hdr.operation is
KVP_OP_GET_IP_INFO in kvp_send_key(), because here we just need to pass on
the op code from the host to the userspace; when the userspace returns
the info requested by the host, we pass the info on to the host in
kvp_respond_to_host() -> process_ob_ipinfo(). BTW, the current buggy code
actually doesn't cause any harm, because only message->kvp_hdr.operation
is used by the userspace, in the case of KVP_OP_GET_IP_INFO.
The patch also adds a missing "break;" in kvp_send_key(). BTW, the current
buggy code actually doesn't cause any harm, because in the case of
KVP_OP_SET, the unexpected fall-through corrupts
message->body.kvp_set.data.key_size, but that is not really used: see
the definition of struct hv_kvp_exchg_msg_value.
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'arch/x86')
0 files changed, 0 insertions, 0 deletions