summaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorAlastair D'Silva <alastair@d-silva.org>2019-08-21 10:19:27 +1000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-08-29 08:28:59 +0200
commit32df8a30b73474403a09b6cc686bc409652a2919 (patch)
tree6cea2b48f5e389181f685c832a2dbd97d20a6bfb /arch
parent0d5e34c1e2633e6256826b8ae2f7fe0d6b3b45d1 (diff)
downloadlinux-stable-32df8a30b73474403a09b6cc686bc409652a2919.tar.gz
linux-stable-32df8a30b73474403a09b6cc686bc409652a2919.tar.bz2
linux-stable-32df8a30b73474403a09b6cc686bc409652a2919.zip
powerpc: Allow flush_(inval_)dcache_range to work across ranges >4GB
The upstream commit: 22e9c88d486a ("powerpc/64: reuse PPC32 static inline flush_dcache_range()") has a similar effect, but since it is a rewrite of the assembler to C, is too invasive for stable. This patch is a minimal fix to address the issue in assembler. This patch applies cleanly to v5.2, v4.19 & v4.14. When calling flush_(inval_)dcache_range with a size >4GB, we were masking off the upper 32 bits, so we would incorrectly flush a range smaller than intended. This patch replaces the 32 bit shifts with 64 bit ones, so that the full size is accounted for. Signed-off-by: Alastair D'Silva <alastair@d-silva.org> Acked-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch')
-rw-r--r--arch/powerpc/kernel/misc_64.S4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/powerpc/kernel/misc_64.S b/arch/powerpc/kernel/misc_64.S
index 262ba9481781..1bf6aaefd26a 100644
--- a/arch/powerpc/kernel/misc_64.S
+++ b/arch/powerpc/kernel/misc_64.S
@@ -135,7 +135,7 @@ _GLOBAL_TOC(flush_dcache_range)
subf r8,r6,r4 /* compute length */
add r8,r8,r5 /* ensure we get enough */
lwz r9,DCACHEL1LOGBLOCKSIZE(r10) /* Get log-2 of dcache block size */
- srw. r8,r8,r9 /* compute line count */
+ srd. r8,r8,r9 /* compute line count */
beqlr /* nothing to do? */
mtctr r8
0: dcbst 0,r6
@@ -153,7 +153,7 @@ _GLOBAL(flush_inval_dcache_range)
subf r8,r6,r4 /* compute length */
add r8,r8,r5 /* ensure we get enough */
lwz r9,DCACHEL1LOGBLOCKSIZE(r10)/* Get log-2 of dcache block size */
- srw. r8,r8,r9 /* compute line count */
+ srd. r8,r8,r9 /* compute line count */
beqlr /* nothing to do? */
sync
isync