diff options
| author | Christoph Hellwig <hch@lst.de> | 2022-04-20 06:27:09 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-05-02 14:06:20 -0600 |
| commit | 2524a5783e7d49e7cd936f582485a2bb4567edd1 (patch) | |
| tree | 3312b61b595bb74c4a21c94f6676afbe5064d325 /block/blk-cgroup.h | |
| parent | 9650b453a3d4b1b8ed4ea8bcb9b40109608d1faf (diff) | |
| download | linux-stable-2524a5783e7d49e7cd936f582485a2bb4567edd1.tar.gz linux-stable-2524a5783e7d49e7cd936f582485a2bb4567edd1.tar.bz2 linux-stable-2524a5783e7d49e7cd936f582485a2bb4567edd1.zip | |
blk-cgroup: remove __bio_blkcg
Remove the unused and deprecated __bio_blkcg helper.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20220420042723.1010598-2-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-cgroup.h')
| -rw-r--r-- | block/blk-cgroup.h | 23 |
1 files changed, 0 insertions, 23 deletions
diff --git a/block/blk-cgroup.h b/block/blk-cgroup.h index 47e1e38390c9..49e88fc9cc39 100644 --- a/block/blk-cgroup.h +++ b/block/blk-cgroup.h @@ -140,27 +140,6 @@ static inline struct cgroup_subsys_state *blkcg_css(void) } /** - * __bio_blkcg - internal, inconsistent version to get blkcg - * - * DO NOT USE. - * This function is inconsistent and consequently is dangerous to use. The - * first part of the function returns a blkcg where a reference is owned by the - * bio. This means it does not need to be rcu protected as it cannot go away - * with the bio owning a reference to it. However, the latter potentially gets - * it from task_css(). This can race against task migration and the cgroup - * dying. It is also semantically different as it must be called rcu protected - * and is susceptible to failure when trying to get a reference to it. - * Therefore, it is not ok to assume that *_get() will always succeed on the - * blkcg returned here. - */ -static inline struct blkcg *__bio_blkcg(struct bio *bio) -{ - if (bio && bio->bi_blkg) - return bio->bi_blkg->blkcg; - return css_to_blkcg(blkcg_css()); -} - -/** * bio_issue_as_root_blkg - see if this bio needs to be issued as root blkg * @return: true if this bio needs to be submitted with the root blkg context. * @@ -471,8 +450,6 @@ static inline int blkcg_activate_policy(struct request_queue *q, static inline void blkcg_deactivate_policy(struct request_queue *q, const struct blkcg_policy *pol) { } -static inline struct blkcg *__bio_blkcg(struct bio *bio) { return NULL; } - static inline struct blkg_policy_data *blkg_to_pd(struct blkcg_gq *blkg, struct blkcg_policy *pol) { return NULL; } static inline struct blkcg_gq *pd_to_blkg(struct blkg_policy_data *pd) { return NULL; } |