diff options
| author | Navid Emamdoost <navid.emamdoost@gmail.com> | 2019-10-04 14:29:16 -0500 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2019-12-10 18:01:32 +0000 |
| commit | 52373b487ee420c43e1d9d01b4b8c11bb6e9bdbf (patch) | |
| tree | 8959029b369556007bf85c9042fe54d9385b8345 /crypto | |
| parent | ea8e4f792da5652f23481231e252f06221b73445 (diff) | |
| download | linux-stable-52373b487ee420c43e1d9d01b4b8c11bb6e9bdbf.tar.gz linux-stable-52373b487ee420c43e1d9d01b4b8c11bb6e9bdbf.tar.bz2 linux-stable-52373b487ee420c43e1d9d01b4b8c11bb6e9bdbf.zip | |
crypto: user - fix memory leak in crypto_report
commit ffdde5932042600c6807d46c1550b28b0db6a3bc upstream.
In crypto_report, a new skb is created via nlmsg_new(). This skb should
be released if crypto_report_alg() fails.
Fixes: a38f7907b926 ("crypto: Add userspace configuration API")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
[bwh: Backported to 3.16: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/crypto_user.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c index 03380bb8430f..05b7e619d896 100644 --- a/crypto/crypto_user.c +++ b/crypto/crypto_user.c @@ -230,8 +230,10 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh, drop_alg: crypto_mod_put(alg); - if (err) + if (err) { + kfree_skb(skb); return err; + } return nlmsg_unicast(crypto_nlsk, skb, NETLINK_CB(in_skb).portid); } |