summaryrefslogtreecommitdiffstats
path: root/crypto
diff options
context:
space:
mode:
authorNavid Emamdoost <navid.emamdoost@gmail.com>2019-10-04 14:29:16 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-12-17 20:38:55 +0100
commit41b3b8e0775465c33083ce1998df7f15c039c9bf (patch)
treef9ae5eb803dabb37057dbb133dfefc7ce114c801 /crypto
parentcfb63e86ff0ebfd7419d1cb85a6c55d4b9380613 (diff)
downloadlinux-stable-41b3b8e0775465c33083ce1998df7f15c039c9bf.tar.gz
linux-stable-41b3b8e0775465c33083ce1998df7f15c039c9bf.tar.bz2
linux-stable-41b3b8e0775465c33083ce1998df7f15c039c9bf.zip
crypto: user - fix memory leak in crypto_report
commit ffdde5932042600c6807d46c1550b28b0db6a3bc upstream. In crypto_report, a new skb is created via nlmsg_new(). This skb should be released if crypto_report_alg() fails. Fixes: a38f7907b926 ("crypto: Add userspace configuration API") Cc: <stable@vger.kernel.org> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'crypto')
-rw-r--r--crypto/crypto_user.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c
index 5e457a7dd1c9..b6899be8065d 100644
--- a/crypto/crypto_user.c
+++ b/crypto/crypto_user.c
@@ -288,8 +288,10 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
drop_alg:
crypto_mod_put(alg);
- if (err)
+ if (err) {
+ kfree_skb(skb);
return err;
+ }
return nlmsg_unicast(crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
}