summaryrefslogtreecommitdiffstats
path: root/crypto
diff options
context:
space:
mode:
authorNavid Emamdoost <navid.emamdoost@gmail.com>2019-10-04 14:29:16 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-12-13 08:49:32 +0100
commitceddd48c8407c4d1c70a815ae229f34c9af44273 (patch)
tree2a18f7655e76bc3b1c336ada64326bab538ab1fc /crypto
parent5128dd94438ec43dacbd947641aac8dea90bbf56 (diff)
downloadlinux-stable-ceddd48c8407c4d1c70a815ae229f34c9af44273.tar.gz
linux-stable-ceddd48c8407c4d1c70a815ae229f34c9af44273.tar.bz2
linux-stable-ceddd48c8407c4d1c70a815ae229f34c9af44273.zip
crypto: user - fix memory leak in crypto_report
commit ffdde5932042600c6807d46c1550b28b0db6a3bc upstream. In crypto_report, a new skb is created via nlmsg_new(). This skb should be released if crypto_report_alg() fails. Fixes: a38f7907b926 ("crypto: Add userspace configuration API") Cc: <stable@vger.kernel.org> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'crypto')
-rw-r--r--crypto/crypto_user_base.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/crypto_user_base.c b/crypto/crypto_user_base.c
index c65e39005ce2..a4db71846af5 100644
--- a/crypto/crypto_user_base.c
+++ b/crypto/crypto_user_base.c
@@ -214,8 +214,10 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
drop_alg:
crypto_mod_put(alg);
- if (err)
+ if (err) {
+ kfree_skb(skb);
return err;
+ }
return nlmsg_unicast(crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
}