summaryrefslogtreecommitdiffstats
path: root/crypto
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2019-11-19 17:41:31 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-02-05 14:43:32 +0000
commit47ef5cb878817127bd3d54c3578bbbd3f7c2bf2c (patch)
tree8ed86b17b30f0ec7c93e265c84e5cd3f3d5c1d6c /crypto
parentcc071b7c434fb50c1afa34d9d852eacf03044f85 (diff)
downloadlinux-stable-47ef5cb878817127bd3d54c3578bbbd3f7c2bf2c.tar.gz
linux-stable-47ef5cb878817127bd3d54c3578bbbd3f7c2bf2c.tar.bz2
linux-stable-47ef5cb878817127bd3d54c3578bbbd3f7c2bf2c.zip
crypto: pcrypt - Fix user-after-free on module unload
[ Upstream commit 07bfd9bdf568a38d9440c607b72342036011f727 ] On module unload of pcrypt we must unregister the crypto algorithms first and then tear down the padata structure. As otherwise the crypto algorithms are still alive and can be used while the padata structure is being freed. Fixes: 5068c7a883d1 ("crypto: pcrypt - Add pcrypt crypto...") Cc: <stable@vger.kernel.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'crypto')
-rw-r--r--crypto/pcrypt.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c
index a5718c0a3dc4..1348541da463 100644
--- a/crypto/pcrypt.c
+++ b/crypto/pcrypt.c
@@ -505,11 +505,12 @@ err:
static void __exit pcrypt_exit(void)
{
+ crypto_unregister_template(&pcrypt_tmpl);
+
pcrypt_fini_padata(&pencrypt);
pcrypt_fini_padata(&pdecrypt);
kset_unregister(pcrypt_kset);
- crypto_unregister_template(&pcrypt_tmpl);
}
module_init(pcrypt_init);