summaryrefslogtreecommitdiffstats
path: root/crypto
diff options
context:
space:
mode:
authorVincent Whitchurch <vincent.whitchurch@axis.com>2019-07-02 09:53:25 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-07-10 09:53:41 +0200
commitae3fa28f09380836e336c236851ff7375c3af590 (patch)
tree2e301441dcb1c71d5c97b7efb21ddce405d2e611 /crypto
parent015c20532ace63c6b2d27326430f2fd177306003 (diff)
downloadlinux-stable-ae3fa28f09380836e336c236851ff7375c3af590.tar.gz
linux-stable-ae3fa28f09380836e336c236851ff7375c3af590.tar.bz2
linux-stable-ae3fa28f09380836e336c236851ff7375c3af590.zip
crypto: cryptd - Fix skcipher instance memory leak
commit 1a0fad630e0b7cff38e7691b28b0517cfbb0633f upstream. cryptd_skcipher_free() fails to free the struct skcipher_instance allocated in cryptd_create_skcipher(), leading to a memory leak. This is detected by kmemleak on bootup on ARM64 platforms: unreferenced object 0xffff80003377b180 (size 1024): comm "cryptomgr_probe", pid 822, jiffies 4294894830 (age 52.760s) backtrace: kmem_cache_alloc_trace+0x270/0x2d0 cryptd_create+0x990/0x124c cryptomgr_probe+0x5c/0x1e8 kthread+0x258/0x318 ret_from_fork+0x10/0x1c Fixes: 4e0958d19bd8 ("crypto: cryptd - Add support for skcipher") Cc: <stable@vger.kernel.org> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'crypto')
-rw-r--r--crypto/cryptd.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/crypto/cryptd.c b/crypto/cryptd.c
index addca7bae33f..e0c8e907b086 100644
--- a/crypto/cryptd.c
+++ b/crypto/cryptd.c
@@ -586,6 +586,7 @@ static void cryptd_skcipher_free(struct skcipher_instance *inst)
struct skcipherd_instance_ctx *ctx = skcipher_instance_ctx(inst);
crypto_drop_skcipher(&ctx->spawn);
+ kfree(inst);
}
static int cryptd_create_skcipher(struct crypto_template *tmpl,