summaryrefslogtreecommitdiffstats
path: root/drivers/android
diff options
context:
space:
mode:
authorTodd Kjos <tkjos@android.com>2019-02-14 15:22:57 -0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-02-15 08:49:20 +0100
commit26528be6720bb40bc8844e97ee73a37e530e9c5e (patch)
tree88343b6e0b00057f70aec941ea9fa151a6bb7f0b /drivers/android
parent36f30937922ce75390c73f99e650e4f2eb56b0e6 (diff)
downloadlinux-stable-26528be6720bb40bc8844e97ee73a37e530e9c5e.tar.gz
linux-stable-26528be6720bb40bc8844e97ee73a37e530e9c5e.tar.bz2
linux-stable-26528be6720bb40bc8844e97ee73a37e530e9c5e.zip
binder: fix handling of misaligned binder object
Fixes crash found by syzbot: kernel BUG at drivers/android/binder_alloc.c:LINE! (2) Reported-and-tested-by: syzbot+55de1eb4975dec156d8f@syzkaller.appspotmail.com Signed-off-by: Todd Kjos <tkjos@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/android')
-rw-r--r--drivers/android/binder.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 2dba539eb792..8685882da64c 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2057,7 +2057,7 @@ static size_t binder_get_object(struct binder_proc *proc,
size_t object_size = 0;
read_size = min_t(size_t, sizeof(*object), buffer->data_size - offset);
- if (read_size < sizeof(*hdr))
+ if (read_size < sizeof(*hdr) || !IS_ALIGNED(offset, sizeof(u32)))
return 0;
binder_alloc_copy_from_buffer(&proc->alloc, object, buffer,
offset, read_size);