diff options
| author | Damien Le Moal <damien.lemoal@wdc.com> | 2021-08-16 10:44:47 +0900 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-15 09:50:26 +0200 |
| commit | fc4073df2968a464a58af8be1240cecf393369ea (patch) | |
| tree | db1d0a592be91f9ee725ed10db229b528a1d2682 /drivers/ata | |
| parent | cf619a528e010fb6017a45bf8af275110d62d53b (diff) | |
| download | linux-stable-fc4073df2968a464a58af8be1240cecf393369ea.tar.gz linux-stable-fc4073df2968a464a58af8be1240cecf393369ea.tar.bz2 linux-stable-fc4073df2968a464a58af8be1240cecf393369ea.zip | |
libata: fix ata_host_start()
[ Upstream commit 355a8031dc174450ccad2a61c513ad7222d87a97 ]
The loop on entry of ata_host_start() may not initialize host->ops to a
non NULL value. The test on the host_stop field of host->ops must then
be preceded by a check that host->ops is not NULL.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20210816014456.2191776-3-damien.lemoal@wdc.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/libata-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 61c762961ca8..44f434acfce0 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5573,7 +5573,7 @@ int ata_host_start(struct ata_host *host) have_stop = 1; } - if (host->ops->host_stop) + if (host->ops && host->ops->host_stop) have_stop = 1; if (have_stop) { |