diff options
| author | Tong Zhang <ztong0001@gmail.com> | 2021-03-07 22:25:30 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-03-30 14:36:58 +0200 |
| commit | f859f5089bd47c3ef830b7f398ca4130f7c5d90b (patch) | |
| tree | 3e47bbf290f77e8e823ba9c7743e105ad07a3230 /drivers/atm | |
| parent | e3c084e6a85b90bdc1acd280dd51fc6d70d515f8 (diff) | |
| download | linux-stable-f859f5089bd47c3ef830b7f398ca4130f7c5d90b.tar.gz linux-stable-f859f5089bd47c3ef830b7f398ca4130f7c5d90b.tar.bz2 linux-stable-f859f5089bd47c3ef830b7f398ca4130f7c5d90b.zip | |
atm: idt77252: fix null-ptr-dereference
[ Upstream commit 4416e98594dc04590ebc498fc4e530009535c511 ]
this one is similar to the phy_data allocation fix in uPD98402, the
driver allocate the idt77105_priv and store to dev_data but later
dereference using dev->dev_data, which will cause null-ptr-dereference.
fix this issue by changing dev_data to phy_data so that PRIV(dev) can
work correctly.
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/atm')
| -rw-r--r-- | drivers/atm/idt77105.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/atm/idt77105.c b/drivers/atm/idt77105.c index 0a67487c0b1d..a2ecb4190f78 100644 --- a/drivers/atm/idt77105.c +++ b/drivers/atm/idt77105.c @@ -261,7 +261,7 @@ static int idt77105_start(struct atm_dev *dev) { unsigned long flags; - if (!(dev->dev_data = kmalloc(sizeof(struct idt77105_priv),GFP_KERNEL))) + if (!(dev->phy_data = kmalloc(sizeof(struct idt77105_priv),GFP_KERNEL))) return -ENOMEM; PRIV(dev)->dev = dev; spin_lock_irqsave(&idt77105_priv_lock, flags); @@ -336,7 +336,7 @@ static int idt77105_stop(struct atm_dev *dev) else idt77105_all = walk->next; dev->phy = NULL; - dev->dev_data = NULL; + dev->phy_data = NULL; kfree(walk); break; } |