summaryrefslogtreecommitdiffstats
path: root/drivers/base/firmware_loader/firmware.h
diff options
context:
space:
mode:
authorAnirudh Rayabharam <mail@anirudhrb.com>2021-07-28 14:21:06 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-08-12 13:19:41 +0200
commitce699ac03ec0e41347363e1cf0924669f5449e34 (patch)
tree8d799ce861fbd64c60095b6f0072101117ee9d49 /drivers/base/firmware_loader/firmware.h
parentc660c337e846be1be897e2d71c3ebbf1763743cb (diff)
downloadlinux-stable-ce699ac03ec0e41347363e1cf0924669f5449e34.tar.gz
linux-stable-ce699ac03ec0e41347363e1cf0924669f5449e34.tar.bz2
linux-stable-ce699ac03ec0e41347363e1cf0924669f5449e34.zip
firmware_loader: use -ETIMEDOUT instead of -EAGAIN in fw_load_sysfs_fallback
commit 0d6434e10b5377a006f6dd995c8fc5e2d82acddc upstream. The only motivation for using -EAGAIN in commit 0542ad88fbdd81bb ("firmware loader: Fix _request_firmware_load() return val for fw load abort") was to distinguish the error from -ENOMEM, and so there is no real reason in keeping it. -EAGAIN is typically used to tell the userspace to try something again and in this case re-using the sysfs loading interface cannot be retried when a timeout happens, so the return value is also bogus. -ETIMEDOUT is received when the wait times out and returning that is much more telling of what the reason for the failure was. So, just propagate that instead of returning -EAGAIN. Suggested-by: Luis Chamberlain <mcgrof@kernel.org> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> Acked-by: Luis Chamberlain <mcgrof@kernel.org> Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20210728085107.4141-2-mail@anirudhrb.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base/firmware_loader/firmware.h')
0 files changed, 0 insertions, 0 deletions