diff options
| author | Tomas Bortoli <tomasbortoli@gmail.com> | 2019-05-28 15:42:58 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-07-26 09:14:16 +0200 |
| commit | 578658df21d58cd7f41e6f68d64655c2cc9d8a74 (patch) | |
| tree | a78fbbb017113bcd46f236893228326b4ff8ad91 /drivers/bluetooth | |
| parent | 9d47bd2175396a57d08521b3f09be9aa06a55a97 (diff) | |
| download | linux-stable-578658df21d58cd7f41e6f68d64655c2cc9d8a74.tar.gz linux-stable-578658df21d58cd7f41e6f68d64655c2cc9d8a74.tar.bz2 linux-stable-578658df21d58cd7f41e6f68d64655c2cc9d8a74.zip | |
Bluetooth: hci_bcsp: Fix memory leak in rx_skb
[ Upstream commit 4ce9146e0370fcd573f0372d9b4e5a211112567c ]
Syzkaller found that it is possible to provoke a memory leak by
never freeing rx_skb in struct bcsp_struct.
Fix by freeing in bcsp_close()
Signed-off-by: Tomas Bortoli <tomasbortoli@gmail.com>
Reported-by: syzbot+98162c885993b72f19c4@syzkaller.appspotmail.com
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/bluetooth')
| -rw-r--r-- | drivers/bluetooth/hci_bcsp.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c index 1a7f0c82fb36..66fe1e6dc631 100644 --- a/drivers/bluetooth/hci_bcsp.c +++ b/drivers/bluetooth/hci_bcsp.c @@ -759,6 +759,11 @@ static int bcsp_close(struct hci_uart *hu) skb_queue_purge(&bcsp->rel); skb_queue_purge(&bcsp->unrel); + if (bcsp->rx_skb) { + kfree_skb(bcsp->rx_skb); + bcsp->rx_skb = NULL; + } + kfree(bcsp); return 0; } |