diff options
author | Stephen Boyd <swboyd@chromium.org> | 2019-07-30 11:15:04 -0700 |
---|---|---|
committer | Daniel Lezcano <daniel.lezcano@linaro.org> | 2019-08-27 00:31:39 +0200 |
commit | 9f475d084c032116cbecd4dc840003dc36465db5 (patch) | |
tree | a633542f417e909ce612b16467bd4cb8632a4ce2 /drivers/clocksource/em_sti.c | |
parent | 3e2d94535adb2df15f3907e4b4c7cd8a5a4c2b5a (diff) | |
download | linux-stable-9f475d084c032116cbecd4dc840003dc36465db5.tar.gz linux-stable-9f475d084c032116cbecd4dc840003dc36465db5.tar.bz2 linux-stable-9f475d084c032116cbecd4dc840003dc36465db5.zip |
clocksource: Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.
// <smpl>
@@
expression ret;
struct platform_device *E;
@@
ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);
if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>
While we're here, remove braces on if statements that only have one
statement (manually).
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Diffstat (limited to 'drivers/clocksource/em_sti.c')
-rw-r--r-- | drivers/clocksource/em_sti.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c index 8e12b11e81b0..9039df4f90e2 100644 --- a/drivers/clocksource/em_sti.c +++ b/drivers/clocksource/em_sti.c @@ -291,10 +291,8 @@ static int em_sti_probe(struct platform_device *pdev) platform_set_drvdata(pdev, p); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "failed to get irq\n"); + if (irq < 0) return irq; - } /* map memory, let base point to the STI instance */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |