diff options
| author | Tong Zhang <ztong0001@gmail.com> | 2022-02-11 23:11:11 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-04-08 14:23:31 +0200 |
| commit | e2951eaa9398415ac054b7bd80b8163b6838ead4 (patch) | |
| tree | 75881bd0c399c2a19abfc5e8fd9b5a9082d2ca8c /drivers/dax | |
| parent | c08208f2635c47c8ad7bc6e860122dfb3c75d91d (diff) | |
| download | linux-stable-e2951eaa9398415ac054b7bd80b8163b6838ead4.tar.gz linux-stable-e2951eaa9398415ac054b7bd80b8163b6838ead4.tar.bz2 linux-stable-e2951eaa9398415ac054b7bd80b8163b6838ead4.zip | |
dax: make sure inodes are flushed before destroy cache
[ Upstream commit a7e8de822e0b1979f08767c751f6c8a9c1d4ad86 ]
A bug can be triggered by following command
$ modprobe nd_pmem && modprobe -r nd_pmem
[ 10.060014] BUG dax_cache (Not tainted): Objects remaining in dax_cache on __kmem_cache_shutdown()
[ 10.060938] Slab 0x0000000085b729ac objects=9 used=1 fp=0x000000004f5ae469 flags=0x200000000010200(slab|head|node)
[ 10.062433] Call Trace:
[ 10.062673] dump_stack_lvl+0x34/0x44
[ 10.062865] slab_err+0x90/0xd0
[ 10.063619] __kmem_cache_shutdown+0x13b/0x2f0
[ 10.063848] kmem_cache_destroy+0x4a/0x110
[ 10.064058] __x64_sys_delete_module+0x265/0x300
This is caused by dax_fs_exit() not flushing inodes before destroy cache.
To fix this issue, call rcu_barrier() before destroy cache.
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20220212071111.148575-1-ztong0001@gmail.com
Fixes: 7b6be8444e0f ("dax: refactor dax-fs into a generic provider of 'struct dax_device' instances")
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/dax')
| -rw-r--r-- | drivers/dax/super.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/dax/super.c b/drivers/dax/super.c index fc89e91beea7..7610e4a9ac4e 100644 --- a/drivers/dax/super.c +++ b/drivers/dax/super.c @@ -678,6 +678,7 @@ static int dax_fs_init(void) static void dax_fs_exit(void) { kern_unmount(dax_mnt); + rcu_barrier(); kmem_cache_destroy(dax_cache); } |