diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2020-04-28 14:35:18 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2020-04-28 21:46:35 +0530 |
| commit | aa72f1d20ee973d68f26d46fce5e1cf6f9b7e1ca (patch) | |
| tree | 23f02b3989a1f87039c88f09285a2ba52c0854e4 /drivers/dma/dmatest.c | |
| parent | b9f960201249f20deea586b4ec814669b4c6b1c0 (diff) | |
| download | linux-stable-aa72f1d20ee973d68f26d46fce5e1cf6f9b7e1ca.tar.gz linux-stable-aa72f1d20ee973d68f26d46fce5e1cf6f9b7e1ca.tar.bz2 linux-stable-aa72f1d20ee973d68f26d46fce5e1cf6f9b7e1ca.zip | |
dmaengine: dmatest: Fix process hang when reading 'wait' parameter
If we do
% echo 1 > /sys/module/dmatest/parameters/run
[ 115.851124] dmatest: Could not start test, no channels configured
% echo dma8chan7 > /sys/module/dmatest/parameters/channel
[ 127.563872] dmatest: Added 1 threads using dma8chan7
% cat /sys/module/dmatest/parameters/wait
... !!! HANG !!! ...
The culprit is the commit 6138f967bccc
("dmaengine: dmatest: Use fixed point div to calculate iops")
which makes threads not to run, but pending and being kicked off by writing
to the 'run' node. However, it forgot to consider 'wait' routine to avoid
above mentioned case.
In order to fix this, check for really running threads, i.e. with pending
and done flags unset.
It's pity the culprit commit hadn't updated documentation and tested all
possible scenarios.
Fixes: 6138f967bccc ("dmaengine: dmatest: Use fixed point div to calculate iops")
Cc: Seraj Alijan <seraj.alijan@sondrel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200428113518.70620-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/dmatest.c')
| -rw-r--r-- | drivers/dma/dmatest.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index 4993e3e5c5b0..364dd34799d4 100644 --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c @@ -240,7 +240,7 @@ static bool is_threaded_test_run(struct dmatest_info *info) struct dmatest_thread *thread; list_for_each_entry(thread, &dtc->threads, node) { - if (!thread->done) + if (!thread->done && !thread->pending) return true; } } |