summaryrefslogtreecommitdiffstats
path: root/drivers/dma/fsldma.c
diff options
context:
space:
mode:
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>2020-12-12 17:05:16 +0100
committerVinod Koul <vkoul@kernel.org>2021-01-12 18:00:39 +0530
commitcbc0ad004c03ad7971726a5db3ec84dba3dcb857 (patch)
tree681588635683b3adc57ed4c133dd270533f7922c /drivers/dma/fsldma.c
parent32d31c79a1a4fbc48aab594a4dc9ffa087ab59a3 (diff)
downloadlinux-stable-cbc0ad004c03ad7971726a5db3ec84dba3dcb857.tar.gz
linux-stable-cbc0ad004c03ad7971726a5db3ec84dba3dcb857.tar.bz2
linux-stable-cbc0ad004c03ad7971726a5db3ec84dba3dcb857.zip
dmaengine: fsldma: Fix a resource leak in the remove function
A 'irq_dispose_mapping()' call is missing in the remove function. Add it. This is needed to undo the 'irq_of_parse_and_map() call from the probe function and already part of the error handling path of the probe function. It was added in the probe function only in commit d3f620b2c4fe ("fsldma: simplify IRQ probing and handling") Fixes: 77cd62e8082b ("fsldma: allow Freescale Elo DMA driver to be compiled as a module") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/20201212160516.92515-1-christophe.jaillet@wanadoo.fr Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/fsldma.c')
-rw-r--r--drivers/dma/fsldma.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 0feb323bae1e..554f70a0c18c 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -1314,6 +1314,7 @@ static int fsldma_of_remove(struct platform_device *op)
if (fdev->chan[i])
fsl_dma_chan_remove(fdev->chan[i]);
}
+ irq_dispose_mapping(fdev->irq);
iounmap(fdev->regs);
kfree(fdev);