diff options
| author | Yu Kuai <yukuai3@huawei.com> | 2021-07-06 20:45:21 +0800 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2021-08-26 08:36:13 -0400 |
| commit | 11145efd295b0a65fcdadae398f4043300b83567 (patch) | |
| tree | d1a9ba6b7b25f02964ca1f5c98c8c837974625db /drivers/dma/sh/usb-dmac.c | |
| parent | 9c97a0539288d29be2fc49465fc1f5d782aa318a (diff) | |
| download | linux-stable-11145efd295b0a65fcdadae398f4043300b83567.tar.gz linux-stable-11145efd295b0a65fcdadae398f4043300b83567.tar.bz2 linux-stable-11145efd295b0a65fcdadae398f4043300b83567.zip | |
dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe()
[ Upstream commit 1da569fa7ec8cb0591c74aa3050d4ea1397778b4 ]
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by moving the error_pm label above the pm_runtime_put() in
the error path.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20210706124521.1371901-1-yukuai3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/dma/sh/usb-dmac.c')
| -rw-r--r-- | drivers/dma/sh/usb-dmac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c index 8f7ceb698226..1cc06900153e 100644 --- a/drivers/dma/sh/usb-dmac.c +++ b/drivers/dma/sh/usb-dmac.c @@ -855,8 +855,8 @@ static int usb_dmac_probe(struct platform_device *pdev) error: of_dma_controller_free(pdev->dev.of_node); - pm_runtime_put(&pdev->dev); error_pm: + pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev); return ret; } |