summaryrefslogtreecommitdiffstats
path: root/drivers/extcon
diff options
context:
space:
mode:
authorChanwoo Choi <cw00.choi@samsung.com>2016-07-18 15:39:28 +0900
committerKishon Vijay Abraham I <kishon@ti.com>2016-09-10 16:48:48 +0530
commit0143f59de50eee70485be9b658e42495d72698dd (patch)
tree34aa70940b5f40a0c2d803b8aa41ac5878f69551 /drivers/extcon
parent1662622fe595919ef004ef24364a68061052a12f (diff)
downloadlinux-stable-0143f59de50eee70485be9b658e42495d72698dd.tar.gz
linux-stable-0143f59de50eee70485be9b658e42495d72698dd.tar.bz2
linux-stable-0143f59de50eee70485be9b658e42495d72698dd.zip
extcon: Remove the state_store() to prevent the wrong access
This patch removes the state_store() which change the state of external connectors with bit masking on user-space. It is wrong access to modify the change the state of external connectors. Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Diffstat (limited to 'drivers/extcon')
-rw-r--r--drivers/extcon/extcon.c21
1 files changed, 1 insertions, 20 deletions
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 319659c6af28..ad5e4546f82c 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -174,26 +174,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
return count;
}
-
-static ssize_t state_store(struct device *dev, struct device_attribute *attr,
- const char *buf, size_t count)
-{
- u32 state;
- ssize_t ret = 0;
- struct extcon_dev *edev = dev_get_drvdata(dev);
-
- ret = sscanf(buf, "0x%x", &state);
- if (ret == 0)
- ret = -EINVAL;
- else
- ret = extcon_set_state(edev, state);
-
- if (ret < 0)
- return ret;
-
- return count;
-}
-static DEVICE_ATTR_RW(state);
+static DEVICE_ATTR_RO(state);
static ssize_t name_show(struct device *dev, struct device_attribute *attr,
char *buf)