diff options
author | Peter Münster <pm@a16n.net> | 2024-04-24 15:51:52 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-05-02 16:17:13 +0200 |
commit | 1aeede3a0217741120725c4c9cebf039c6fff7ef (patch) | |
tree | b67475626e73e13bb3c123bb165f5aa88d2e430b /drivers/firmware/arm_scmi/scmi_pm_domain.c | |
parent | f5417ff561b8ac9a7e53c747b8627a7ab58378ae (diff) | |
download | linux-stable-1aeede3a0217741120725c4c9cebf039c6fff7ef.tar.gz linux-stable-1aeede3a0217741120725c4c9cebf039c6fff7ef.tar.bz2 linux-stable-1aeede3a0217741120725c4c9cebf039c6fff7ef.zip |
net: b44: set pause params only when interface is up
commit e3eb7dd47bd4806f00e104eb6da092c435f9fb21 upstream.
b44_free_rings() accesses b44::rx_buffers (and ::tx_buffers)
unconditionally, but b44::rx_buffers is only valid when the
device is up (they get allocated in b44_open(), and deallocated
again in b44_close()), any other time these are just a NULL pointers.
So if you try to change the pause params while the network interface
is disabled/administratively down, everything explodes (which likely
netifd tries to do).
Link: https://github.com/openwrt/openwrt/issues/13789
Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2)
Cc: stable@vger.kernel.org
Reported-by: Peter Münster <pm@a16n.net>
Suggested-by: Jonas Gorski <jonas.gorski@gmail.com>
Signed-off-by: Vaclav Svoboda <svoboda@neng.cz>
Tested-by: Peter Münster <pm@a16n.net>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Peter Münster <pm@a16n.net>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/87y192oolj.fsf@a16n.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/firmware/arm_scmi/scmi_pm_domain.c')
0 files changed, 0 insertions, 0 deletions