diff options
| author | Richard Fitzgerald <rf@opensource.cirrus.com> | 2023-06-05 15:32:38 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-06-05 15:35:46 +0100 |
| commit | ad24919540fb4df83981d469b5253cc1aecca939 (patch) | |
| tree | a210fedc7bf220a157e0c2798ae7e82f2d9df739 /drivers/firmware/cirrus | |
| parent | 32cf0046a652116d6a216d575f3049a9ff9dd80d (diff) | |
| download | linux-stable-ad24919540fb4df83981d469b5253cc1aecca939.tar.gz linux-stable-ad24919540fb4df83981d469b5253cc1aecca939.tar.bz2 linux-stable-ad24919540fb4df83981d469b5253cc1aecca939.zip | |
firmware: cs_dsp: Log correct region name in bin error messages
In cs_dsp_load_coeff() region_name should be set in the XM/YM/ZM
cases otherwise any errors will log the region as "Unknown".
While doing this also change one error message that logged the
region type ID to log the region_name instead. This makes it
consistent with other messages in the same function.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230605143238.4001982-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/firmware/cirrus')
| -rw-r--r-- | drivers/firmware/cirrus/cs_dsp.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/firmware/cirrus/cs_dsp.c b/drivers/firmware/cirrus/cs_dsp.c index e4ccfb6a8fa5..ec056f6f40ce 100644 --- a/drivers/firmware/cirrus/cs_dsp.c +++ b/drivers/firmware/cirrus/cs_dsp.c @@ -2124,6 +2124,7 @@ static int cs_dsp_load_coeff(struct cs_dsp *dsp, const struct firmware *firmware file, blocks, le32_to_cpu(blk->len), type, le32_to_cpu(blk->id)); + region_name = cs_dsp_mem_region_name(type); mem = cs_dsp_find_region(dsp, type); if (!mem) { cs_dsp_err(dsp, "No base for region %x\n", type); @@ -2147,8 +2148,8 @@ static int cs_dsp_load_coeff(struct cs_dsp *dsp, const struct firmware *firmware reg = dsp->ops->region_to_reg(mem, reg); reg += offset; } else { - cs_dsp_err(dsp, "No %x for algorithm %x\n", - type, le32_to_cpu(blk->id)); + cs_dsp_err(dsp, "No %s for algorithm %x\n", + region_name, le32_to_cpu(blk->id)); } break; |