summaryrefslogtreecommitdiffstats
path: root/drivers/gpio/Kconfig
diff options
context:
space:
mode:
authorSascha Hauer <s.hauer@pengutronix.de>2016-10-21 15:11:38 +0200
committerLinus Walleij <linus.walleij@linaro.org>2016-10-24 16:33:11 +0200
commitf08ea3cc94eeaf938ad9da86014e8fee79299458 (patch)
tree16f852d0f65c328e217ebd6bdec6e1ffe2228fc6 /drivers/gpio/Kconfig
parent66a37c3bbf7348758a154fe99f8035df2874ebeb (diff)
downloadlinux-stable-f08ea3cc94eeaf938ad9da86014e8fee79299458.tar.gz
linux-stable-f08ea3cc94eeaf938ad9da86014e8fee79299458.tar.bz2
linux-stable-f08ea3cc94eeaf938ad9da86014e8fee79299458.zip
gpio: mxs: fix duplicate level interrupts
According to the reference manual level interrupts can't be acked using the IRQSTAT registers. The effect is that when a level interrupt triggers the following ack is a no-op and the same interrupt triggers again right after it has been unmasked after running the interrupt handler. The reference manual says: Status bits for pins configured as level sensitive interrupts cannot be cleared unless either the actual pin is in the non-interrupting state, or the pin has been disabled as an interrupt source by clearing its bit in HW_PINCTRL_PIN2IRQ. To work around the duplicated interrupts we can use the PIN2IRQ rather than the IRQEN registers to mask the interrupts. This probably does not work for the edge interrupts, so we have to split up the irq chip into two chip types, one for the level interrupts and one for the edge interrupts. We now make use of two different enable registers, so we have to take care to always enable the right one, especially during switching of the interrupt type. An easy way to accomplish this is to use the IRQCHIP_SET_TYPE_MASKED which makes sure that set_irq_type is called with masked interrupts. With this the flow to change the irq type is like: - core masks interrupt (using the current chip type) - mxs_gpio_set_irq_type() changes chip type if necessary - mxs_gpio_set_irq_type() unconditionally sets the enable bit in the now unused enable register - core eventually unmasks the interrupt (using the new chip type) Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Reviewed-by: Marek Vasut <marex@denx.de> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/Kconfig')
0 files changed, 0 insertions, 0 deletions