diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2015-12-21 11:21:47 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2015-12-26 22:28:18 +0100 |
| commit | db30aaef313b4d5a2f6151e61e4f3ab5e0affae4 (patch) | |
| tree | 211103f56c9c8bb37c58d8841f1a98d0ea878db4 /drivers/gpio/gpio-msic.c | |
| parent | c759174e73ab4a2190244c903649032ac748586d (diff) | |
| download | linux-stable-db30aaef313b4d5a2f6151e61e4f3ab5e0affae4.tar.gz linux-stable-db30aaef313b4d5a2f6151e61e4f3ab5e0affae4.tar.bz2 linux-stable-db30aaef313b4d5a2f6151e61e4f3ab5e0affae4.zip | |
gpio: msic: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-msic.c')
| -rw-r--r-- | drivers/gpio/gpio-msic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-msic.c b/drivers/gpio/gpio-msic.c index fe9ef2bc981a..9a261acb0eed 100644 --- a/drivers/gpio/gpio-msic.c +++ b/drivers/gpio/gpio-msic.c @@ -143,7 +143,7 @@ static int msic_gpio_get(struct gpio_chip *chip, unsigned offset) if (ret < 0) return ret; - return r & MSIC_GPIO_DIN_MASK; + return !!(r & MSIC_GPIO_DIN_MASK); } static void msic_gpio_set(struct gpio_chip *chip, unsigned offset, int value) |