diff options
| author | Vignesh R <vigneshr@ti.com> | 2016-06-09 11:02:04 +0530 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2016-11-20 01:16:40 +0000 |
| commit | e8f14f88365a1d7a1bc916f2ccfa3fb01e9f25b7 (patch) | |
| tree | 94f9cb5de3930dc037f7529338bab15621eee65a /drivers/gpio | |
| parent | dce26aa0a86cdde59012bb05cdce69480c30c954 (diff) | |
| download | linux-stable-e8f14f88365a1d7a1bc916f2ccfa3fb01e9f25b7.tar.gz linux-stable-e8f14f88365a1d7a1bc916f2ccfa3fb01e9f25b7.tar.bz2 linux-stable-e8f14f88365a1d7a1bc916f2ccfa3fb01e9f25b7.zip | |
gpio: pca953x: Fix NBANK calculation for PCA9536
commit a246b8198f776a16d1d3a3bbfc2d437bad766b29 upstream.
NBANK() macro assumes that ngpios is a multiple of 8(BANK_SZ) and
hence results in 0 banks for PCA9536 which has just 4 gpios. This is
wrong as PCA9356 has 1 bank with 4 gpios. This results in uninitialized
PCA953X_INVERT register. Fix this by using DIV_ROUND_UP macro in
NBANK().
Signed-off-by: Vignesh R <vigneshr@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-pca953x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 103de0f01934..7a92eb0dad6b 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -76,7 +76,7 @@ MODULE_DEVICE_TABLE(i2c, pca953x_id); #define MAX_BANK 5 #define BANK_SZ 8 -#define NBANK(chip) (chip->gpio_chip.ngpio / BANK_SZ) +#define NBANK(chip) DIV_ROUND_UP(chip->gpio_chip.ngpio, BANK_SZ) struct pca953x_chip { unsigned gpio_start; |