diff options
| author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-06-13 14:24:02 +0200 |
|---|---|---|
| committer | Rob Clark <robdclark@chromium.org> | 2019-06-18 13:45:14 -0700 |
| commit | c8bffdcb25ea548b03ccdfa00d19f471010919bc (patch) | |
| tree | f9f5c17da5235ec17e4560ce5a9f844aa34cf5db /drivers/gpu/drm/msm/msm_perf.c | |
| parent | 7aca4d65e7052c1b9905653c948fc6ffc05bfb02 (diff) | |
| download | linux-stable-c8bffdcb25ea548b03ccdfa00d19f471010919bc.tar.gz linux-stable-c8bffdcb25ea548b03ccdfa00d19f471010919bc.tar.bz2 linux-stable-c8bffdcb25ea548b03ccdfa00d19f471010919bc.zip | |
msm: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[small fixup for unused variable warning]
Signed-off-by: Rob Clark <robdclark@chromium.org>
Diffstat (limited to 'drivers/gpu/drm/msm/msm_perf.c')
| -rw-r--r-- | drivers/gpu/drm/msm/msm_perf.c | 15 |
1 files changed, 2 insertions, 13 deletions
diff --git a/drivers/gpu/drm/msm/msm_perf.c b/drivers/gpu/drm/msm/msm_perf.c index 5ab21bd2decb..95948cfe7a12 100644 --- a/drivers/gpu/drm/msm/msm_perf.c +++ b/drivers/gpu/drm/msm/msm_perf.c @@ -205,7 +205,6 @@ int msm_perf_debugfs_init(struct drm_minor *minor) { struct msm_drm_private *priv = minor->dev->dev_private; struct msm_perf_state *perf; - struct dentry *ent; /* only create on first minor: */ if (priv->perf) @@ -220,19 +219,9 @@ int msm_perf_debugfs_init(struct drm_minor *minor) mutex_init(&perf->read_lock); priv->perf = perf; - ent = debugfs_create_file("perf", S_IFREG | S_IRUGO, - minor->debugfs_root, perf, &perf_debugfs_fops); - if (!ent) { - DRM_ERROR("Cannot create /sys/kernel/debug/dri/%pd/perf\n", - minor->debugfs_root); - goto fail; - } - + debugfs_create_file("perf", S_IFREG | S_IRUGO, minor->debugfs_root, + perf, &perf_debugfs_fops); return 0; - -fail: - msm_perf_debugfs_cleanup(priv); - return -1; } void msm_perf_debugfs_cleanup(struct msm_drm_private *priv) |