diff options
| author | Lyude Paul <lyude@redhat.com> | 2018-12-11 18:56:20 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-12-21 14:13:06 +0100 |
| commit | d0a954cbfbd09c9106192f880dbe52bf448f11a8 (patch) | |
| tree | 5e526ffeec45070b3c163e5cd583ba8c7f574b25 /drivers/gpu/drm | |
| parent | e89aa818353bccf626c317f0dee0d1cd7cdc6772 (diff) | |
| download | linux-stable-d0a954cbfbd09c9106192f880dbe52bf448f11a8.tar.gz linux-stable-d0a954cbfbd09c9106192f880dbe52bf448f11a8.tar.bz2 linux-stable-d0a954cbfbd09c9106192f880dbe52bf448f11a8.zip | |
drm/nouveau/kms: Fix memory leak in nv50_mstm_del()
commit 24199c5436f267399afed0c4f1f57663c0408f57 upstream.
Noticed this while working on redoing the reference counting scheme in
the DP MST helpers. Nouveau doesn't attempt to call
drm_dp_mst_topology_mgr_destroy() at all, which leaves it leaking all of
the resources for drm_dp_mst_topology_mgr and it's children mstbs+ports.
Fixes: f479c0ba4a17 ("drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream")
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: <stable@vger.kernel.org> # v4.10+
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/gpu/drm')
| -rw-r--r-- | drivers/gpu/drm/nouveau/nv50_display.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index 926ec51ba5be..25f6a1f6ce20 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b/drivers/gpu/drm/nouveau/nv50_display.c @@ -3378,6 +3378,7 @@ nv50_mstm_del(struct nv50_mstm **pmstm) { struct nv50_mstm *mstm = *pmstm; if (mstm) { + drm_dp_mst_topology_mgr_destroy(&mstm->mgr); kfree(*pmstm); *pmstm = NULL; } |