diff options
| author | Benjamin Tissoires <benjamin.tissoires@redhat.com> | 2019-08-12 18:27:39 +0200 |
|---|---|---|
| committer | Benjamin Tissoires <benjamin.tissoires@redhat.com> | 2019-08-22 17:11:58 +0200 |
| commit | 87fcb6a69e54527ccaeb5878168cccdba9f6b6ae (patch) | |
| tree | e0aacd9f60504384cc942f0bdbb37ae9c7f04d63 /drivers/hid/hid-gfrm.c | |
| parent | 15d90b242290f228166ea79ee1cc2db6b31a2143 (diff) | |
| download | linux-stable-87fcb6a69e54527ccaeb5878168cccdba9f6b6ae.tar.gz linux-stable-87fcb6a69e54527ccaeb5878168cccdba9f6b6ae.tar.bz2 linux-stable-87fcb6a69e54527ccaeb5878168cccdba9f6b6ae.zip | |
HID: do not call hid_set_drvdata(hdev, NULL) in drivers
This is a common pattern in the HID drivers to reset the drvdata. Some
do it properly, some do it only in case of failure.
But, this is actually already handled by driver core, so there is no need
to do it manually.
[for hid-sensor-hub.c]
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
[For hid-picolcd_core.c]
Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Diffstat (limited to 'drivers/hid/hid-gfrm.c')
| -rw-r--r-- | drivers/hid/hid-gfrm.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/hid/hid-gfrm.c b/drivers/hid/hid-gfrm.c index 86c317320bf2..699186ff2349 100644 --- a/drivers/hid/hid-gfrm.c +++ b/drivers/hid/hid-gfrm.c @@ -123,12 +123,6 @@ done: return ret; } -static void gfrm_remove(struct hid_device *hdev) -{ - hid_hw_stop(hdev); - hid_set_drvdata(hdev, NULL); -} - static const struct hid_device_id gfrm_devices[] = { { HID_BLUETOOTH_DEVICE(0x58, 0x2000), .driver_data = GFRM100 }, @@ -142,7 +136,6 @@ static struct hid_driver gfrm_driver = { .name = "gfrm", .id_table = gfrm_devices, .probe = gfrm_probe, - .remove = gfrm_remove, .input_mapping = gfrm_input_mapping, .raw_event = gfrm_raw_event, .input_configured = gfrm_input_configured, |