summaryrefslogtreecommitdiffstats
path: root/drivers/hid/hidraw.c
diff options
context:
space:
mode:
authorYonghua Zheng <younghua.zheng@gmail.com>2013-07-30 14:16:10 +0800
committerJiri Kosina <jkosina@suse.cz>2013-07-31 19:48:55 +0200
commit8e552e535948fe8612d36a7beaf19519140bc285 (patch)
tree72e448701c7f02aa85e9fedd1f828616f322f4b0 /drivers/hid/hidraw.c
parent6f498018279d118cf38945f73da7c9345f7e2e5d (diff)
downloadlinux-stable-8e552e535948fe8612d36a7beaf19519140bc285.tar.gz
linux-stable-8e552e535948fe8612d36a7beaf19519140bc285.tar.bz2
linux-stable-8e552e535948fe8612d36a7beaf19519140bc285.zip
HID: hidraw: fix improper mutex release
Mutex can not be released unless all hid_device members are properly initialized. Otherwise it would result in a race condition that can cause NULL pointer kernel panic issue in hidraw_open where it uses uninitialized 'list' member in list_add_tail(). Signed-off-by: Yonghua Zheng <younghua.zheng@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hidraw.c')
-rw-r--r--drivers/hid/hidraw.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index a7451632ceb4..6f1feb2c2e97 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -518,7 +518,6 @@ int hidraw_connect(struct hid_device *hid)
goto out;
}
- mutex_unlock(&minors_lock);
init_waitqueue_head(&dev->wait);
INIT_LIST_HEAD(&dev->list);
@@ -528,6 +527,7 @@ int hidraw_connect(struct hid_device *hid)
dev->exist = 1;
hid->hidraw = dev;
+ mutex_unlock(&minors_lock);
out:
return result;